Skip to content

Conversation

@bix0r
Copy link
Collaborator

@bix0r bix0r commented Dec 4, 2024

@bix0r bix0r requested a review from omars44 December 4, 2024 14:25
@omars44
Copy link
Collaborator

omars44 commented Dec 8, 2024

Hi @bix0r, good to see u're back :)

Let's please work on >= PHP 8.1

The rest are EOLed, we shouldn't really spend any efforts there, either we fully support or not fully support. Let's focus our efforts towards the future, I'm happy to have a call about this if needed.

composer.json Outdated
"license": "PHP-3.01",
"description": "Apache Solr extension",
"require": {
"php": ">= 7.4,<8.5",
Copy link
Collaborator

@omars44 omars44 Dec 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'>= 8.1, <=8.4'

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omars44 I agree that we should aim to sync with PHP on the versions. At least for this new pie stuff. Perhaps not remove support for old versions in code unless we need to.

I will rebase the packaging PR when this is merged.

@bix0r
Copy link
Collaborator Author

bix0r commented Dec 30, 2024

I am going to move this PR to draft because there is some discussion on the vendor name for extensions living in github.com/php. See Composer issue.

@bix0r bix0r marked this pull request as draft December 30, 2024 14:27
@omars44
Copy link
Collaborator

omars44 commented Jan 13, 2025

I am going to move this PR to draft because there is some discussion on the vendor name for extensions living in github.com/php. See Composer issue.

sure

@bix0r
Copy link
Collaborator Author

bix0r commented Oct 11, 2025

@remicollet I wonder if we should add this package to the pecl/ namespace?

I see that you have been adding some existing packages to the pecl/ namespace, and according to https://externals.io/message/128536#128614 and a comment on the linked composer issue above, it seems like that would be the way to go.

Otherwise I think that I will just go with php-solr/solr. Other option would be apache/php-solr that has been proposed to me in discussions with some core devs, but I am not sure I like that one.

@remicollet
Copy link
Member

@remicollet I wonder if we should add this package to the pecl/ namespace?

Your choice ;)
In this case, you need someone who already own 1 pecl package to add it in this namespace, and then give you the ownership. (I can do it).

I think "pecl" vendor is useful for extensions inherited from the community with no real author. Also for project in the php github organization (moved from git.php.net)

"apache" may be interesting for all ASF hosted projects, but if used by this extension it will be locked (like the pecl one) so probably only if really managed by the ASF.

I also think "php" or "pie" in the "project" name doesn't make sense (everything is for php on packagist).

"license": "PHP-3.01",
"description": "Apache Solr extension",
"require": {
"php": ">= 8.1,<=8.4",
Copy link
Member

@remicollet remicollet Oct 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think composer.json and package.xml should be consistent.

So 7.4 to 8.4 for released version, but probably 7.4 to 8.5 for next patch version as build/test passes with 8.5.0RC2

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I agree, it should be consistent. I will change this when I change the name.

Then we will remove support for older versions in a separate PR.

@bix0r
Copy link
Collaborator Author

bix0r commented Oct 12, 2025

Thank you for your input @remicollet. I really like your reasoning :)

I think "pecl" vendor is useful for extensions inherited from the community with no real author. Also for project in the php github organization (moved from git.php.net)

Since this package is not heading for major development and is in the php GH organisation, I think pecl is the best suited vendor. If we ever want to do some major refactoring or changes we could then look into moving it to its own organisation and then change the vendor.

@omars44 What do you think?

Your choice ;) In this case, you need someone who already own 1 pecl package to add it in this namespace, and then give you the ownership. (I can do it).

I will ping you if we decide to use pecl. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants