-
Notifications
You must be signed in to change notification settings - Fork 41
Add a composer.json to enable support for PIE #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
e390d98 to
19b4af4
Compare
|
Hi @bix0r, good to see u're back :) Let's please work on >= PHP 8.1 The rest are EOLed, we shouldn't really spend any efforts there, either we fully support or not fully support. Let's focus our efforts towards the future, I'm happy to have a call about this if needed. |
composer.json
Outdated
| "license": "PHP-3.01", | ||
| "description": "Apache Solr extension", | ||
| "require": { | ||
| "php": ">= 7.4,<8.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'>= 8.1, <=8.4'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@omars44 I agree that we should aim to sync with PHP on the versions. At least for this new pie stuff. Perhaps not remove support for old versions in code unless we need to.
I will rebase the packaging PR when this is merged.
|
I am going to move this PR to draft because there is some discussion on the vendor name for extensions living in github.com/php. See Composer issue. |
sure |
|
@remicollet I wonder if we should add this package to the I see that you have been adding some existing packages to the Otherwise I think that I will just go with |
Your choice ;) I think "pecl" vendor is useful for extensions inherited from the community with no real author. Also for project in the php github organization (moved from git.php.net) "apache" may be interesting for all ASF hosted projects, but if used by this extension it will be locked (like the pecl one) so probably only if really managed by the ASF. I also think "php" or "pie" in the "project" name doesn't make sense (everything is for php on packagist). |
| "license": "PHP-3.01", | ||
| "description": "Apache Solr extension", | ||
| "require": { | ||
| "php": ">= 8.1,<=8.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think composer.json and package.xml should be consistent.
So 7.4 to 8.4 for released version, but probably 7.4 to 8.5 for next patch version as build/test passes with 8.5.0RC2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I agree, it should be consistent. I will change this when I change the name.
Then we will remove support for older versions in a separate PR.
|
Thank you for your input @remicollet. I really like your reasoning :)
Since this package is not heading for major development and is in the php GH organisation, I think @omars44 What do you think?
I will ping you if we decide to use |
See: https://github.com/php/pie/blob/main/docs/extension-maintainers.md